-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: messages deepCopy
mutates src
arguments
#1975
Conversation
* fix: messages `deepCopy` mutates `src` arguments * fix: `deepCopy` should never merge arrays
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! ❤️
Sorry the name of this PR is incorrect! (I guess due to the cherry pick process?) It should have been |
deepCopy
mutates src
arguments
no problem! |
<h3>Snyk has created this PR to upgrade vue-i18n from 9.14.0 to 9.14.1.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> - The recommended version is **1 version** ahead of your current version. - The recommended version was released **25 days ago**, on 2024-09-26. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>vue-i18n</b></summary> <ul> <li> <b>9.14.1</b> - <a href="https://snyk.io/redirect/github/intlify/vue-i18n/releases/tag/v9.14.1">2024-09-26</a></br> <h2>What's Changed</h2> <h3>🐛 Bug Fixes</h3> <ul> <li>fix: messages <code>deepCopy</code> mutates <code>src</code> arguments by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/BobbieGoede/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://snyk.io/redirect/github/BobbieGoede">@ BobbieGoede</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2549815383" data-permission-text="Title is private" data-url="intlify/vue-i18n#1975" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1975/hovercard" href="https://snyk.io/redirect/github/intlify/vue-i18n/pull/1975">#1975</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://snyk.io/redirect/github/intlify/vue-i18n/compare/v9.14.0...v9.14.1"><tt>v9.14.0...v9.14.1</tt></a></p> </li> <li> <b>9.14.0</b> - <a href="https://snyk.io/redirect/github/intlify/vue-i18n/releases/tag/v9.14.0">2024-08-16</a></br> <h2>What's Changed</h2> <h3>⚡ Improvement Features</h3> <ul> <li>fix: vue-i18n type definition for vue package by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/BobbieGoede/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://snyk.io/redirect/github/BobbieGoede">@ BobbieGoede</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2470535823" data-permission-text="Title is private" data-url="intlify/vue-i18n#1919" data-hovercard-type="pull_request" data-hovercard-url="/intlify/vue-i18n/pull/1919/hovercard" href="https://snyk.io/redirect/github/intlify/vue-i18n/pull/1919">#1919</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://snyk.io/redirect/github/intlify/vue-i18n/compare/v9.13.1...v9.14.0"><tt>v9.13.1...v9.14.0</tt></a></p> </li> </ul> from <a href="https://snyk.io/redirect/github/intlify/vue-i18n/releases">vue-i18n GitHub release notes</a> </details> </details> <hr/> **Note:** *You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.* For more information: <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiI1YjVkZjViYS00OWIzLTRmNzQtOWFhMy03Nzc3ZWYyZTEwYzYiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjViNWRmNWJhLTQ5YjMtNGY3NC05YWEzLTc3NzdlZjJlMTBjNiJ9fQ==" width="0" height="0"/> 🧐 [View latest project report](https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24?utm_source=github&utm_medium=referral&page=upgrade-pr) 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr) 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24/settings/integration?pkg=vue-i18n&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades) <!--- (snyk:metadata:{"prId":"5b5df5ba-49b3-4f74-9aa3-7777ef2e10c6","prPublicId":"5b5df5ba-49b3-4f74-9aa3-7777ef2e10c6","dependencies":[{"name":"vue-i18n","from":"9.14.0","to":"9.14.1"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"d19c39b4-9b25-4232-b09a-2d71e94c8a24","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2024-09-26T09:05:56.169Z","isPrivateUpgrade":false},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]}) ---> Co-authored-by: snyk-bot <snyk-bot@snyk.io>
This is cherry picked from #1947, hopefully the last backport for v9 😅 This would allow me to resolve the related issues downstream in Nuxt i18n v8 so users don't need to experience it before migrating to the eventual stable Nuxt i18n v9.
Related